Skip to content

Commit

Permalink
Fix/neotraverse (#753)
Browse files Browse the repository at this point in the history
* fix: migrate bloated 'traverse' to 'neotraverse'

* chore: replace devDep 'clone' with integrated structuredClone

* ci: update node-version

* chore: update dependencies

* chore: update nvmrc node version for netlify
  • Loading branch information
fratzinger authored Jul 17, 2024
1 parent 4dbab86 commit 9341a9c
Show file tree
Hide file tree
Showing 8 changed files with 3,649 additions and 2,382 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16.x, 18.x]
node-version: [18.x, 20.x, 22.x]
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
Expand All @@ -19,9 +19,9 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js 18.x
- name: Use Node.js 20.x
uses: actions/setup-node@v3
with:
node-version: 18.x
node-version: 20.x
- run: npm install
- run: npm run compile
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16.15.0
v20.15.1
9 changes: 9 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"search.exclude": {
"**/node_modules": true,
"**/dist": true,
"**/package-lock.json": true,
"**/pnpm-lock.yaml": true
},
}

5,952 changes: 3,607 additions & 2,345 deletions package-lock.json

Large diffs are not rendered by default.

55 changes: 26 additions & 29 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,47 +62,44 @@
"dist/**"
],
"dependencies": {
"@feathersjs/errors": "^5.0.14",
"@feathersjs/errors": "^5.0.29",
"ajv": "^6.12.6",
"debug": "^4.3.4",
"graphql": "^16.8.1",
"debug": "^4.3.5",
"graphql": "^16.9.0",
"lodash": "^4.17.21",
"traverse": "^0.6.8"
"neotraverse": "^0.6.11"
},
"devDependencies": {
"@feathers-plus/batch-loader": "^0.3.6",
"@feathers-plus/cache": "^1.4.0",
"@feathers-plus/graphql": "^1.10.0",
"@feathersjs/authentication": "^5.0.14",
"@feathersjs/authentication-local": "^5.0.14",
"@feathersjs/client": "^5.0.14",
"@feathersjs/express": "^5.0.14",
"@feathersjs/memory": "^5.0.14",
"@feathersjs/socketio": "^5.0.14",
"@feathersjs/socketio-client": "^5.0.14",
"@types/clone": "^2.1.4",
"@feathersjs/authentication": "^5.0.29",
"@feathersjs/authentication-local": "^5.0.29",
"@feathersjs/client": "^5.0.29",
"@feathersjs/express": "^5.0.29",
"@feathersjs/memory": "^5.0.29",
"@feathersjs/socketio": "^5.0.29",
"@feathersjs/socketio-client": "^5.0.29",
"@types/debug": "^4.1.12",
"@types/lodash": "^4.14.202",
"@types/node": "^20.11.4",
"@types/traverse": "^0.6.36",
"@typescript-eslint/eslint-plugin": "^6.19.0",
"@typescript-eslint/parser": "^6.19.0",
"@vitest/coverage-v8": "^1.2.0",
"clone": "^2.1.2",
"eslint": "^8.56.0",
"@types/lodash": "^4.17.7",
"@types/node": "^20.14.11",
"@typescript-eslint/eslint-plugin": "^6.21.0",
"@typescript-eslint/parser": "^6.21.0",
"@vitest/coverage-v8": "^1.6.0",
"eslint": "^8.57.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-prefer-arrow": "^1.2.3",
"eslint-plugin-prettier": "^5.1.3",
"mongodb": "^5.8.0",
"npm-check-updates": "^16.14.12",
"prettier": "^3.2.2",
"eslint-plugin-prettier": "^5.2.1",
"mongodb": "^5.9.2",
"npm-check-updates": "^16.14.20",
"prettier": "^3.3.3",
"shx": "^0.3.4",
"sift": "^17.0.1",
"tsup": "^8.0.1",
"typescript": "^5.3.3",
"vitepress": "^1.0.0-rc.39",
"vitest": "^1.2.0"
"sift": "^17.1.3",
"tsup": "^8.1.2",
"typescript": "^5.5.3",
"vitepress": "^1.3.1",
"vitest": "^1.6.0"
},
"peerDependencies": {
"@feathersjs/feathers": "^5.0.0"
Expand Down
2 changes: 1 addition & 1 deletion src/common/traverse.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import traverser from 'traverse';
import traverser from 'neotraverse';

export function traverse<T extends Record<string, any>>(
items: T | T[],
Expand Down
2 changes: 1 addition & 1 deletion src/hooks/mongo-keys.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { HookContext } from '@feathersjs/feathers';
import traverse from 'traverse';
import traverse from 'neotraverse';
import { checkContext } from '../utils/check-context';

/**
Expand Down
3 changes: 1 addition & 2 deletions test/hooks/run-parallel.test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { assert } from 'vitest';
import clone from 'clone';
import { runParallel } from '../../src';

let contextBefore: any;
Expand Down Expand Up @@ -56,7 +55,7 @@ describe('services runParallel', () => {

it('clones', () =>
new Promise<void>(resolve => {
runParallel(test(tester), clone)(contextBefore);
runParallel(test(tester), structuredClone)(contextBefore);
contextBefore._foo = true;

function tester(contextCloned: any) {
Expand Down

0 comments on commit 9341a9c

Please sign in to comment.