Add support for cross-imports with @x
#103
Conversation
| @@ -44,7 +44,7 @@ const noPublicApiSidestep = { | |||
| } | |||
|
|
|||
| if (isSliced(dependencyLocation.layerName)) { | |||
| if (dependencyLocation.segmentName !== null) { | |||
| if (dependencyLocation.segmentName !== null && dependencyLocation.segmentName !== '@x') { | |||
There was a problem hiding this comment.
Shouldn't such standardized folder names be stored in some self-describing constant (that can be referenced everywhere throughout the project), rather than just a string literal?
There was a problem hiding this comment.
Maybe it should even be provided by feature-sliced/filesystem, but we can temporarily add it locally for the plugin.
There was a problem hiding this comment.
Yeah, good point. I'll add it to the filesystem package
| @@ -23,12 +23,20 @@ const noReservedFolderNames = { | |||
|
|
|||
| for (const violatingFolder of findAllRecursively( | |||
| child, | |||
| (entry) => entry.type === 'folder' && conventionalSegmentNames.includes(basename(entry.path)), | |||
| (entry) => entry.type === 'folder' && conventionalSegmentNames.concat('@x').includes(basename(entry.path)), | |||
There was a problem hiding this comment.
Same as no-public-api-sidestep
|
Excellent job! It's good that you decided to add a separate message for the There was just a single minor call out from me |
Closes #29