Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no-segments-on-sliced-layers rule #54

Merged
merged 11 commits into from
Jul 16, 2024
Merged

Add no-segments-on-sliced-layers rule #54

merged 11 commits into from
Jul 16, 2024

Conversation

daniilsapa
Copy link
Collaborator

@daniilsapa daniilsapa commented Jul 13, 2024 •
edited
Loading

Resolves #25

illright
illright requested changes Jul 13, 2024
View reviewed changes
Copy link
Member

@illright illright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR! I looked over it quickly, thank you for including the changeset and updates to the README :)

I ran the tests and they are failing on Windows. It might have to do with the fact that you split by '/', because Windows paths are separated with \. You can use sep from node:path to fix that

@daniilsapa
Copy link
Collaborator Author

Yes, this is most likely the cause of the problem. Thank you. Fixing the PR

@daniilsapa daniilsapa requested a review from illright July 13, 2024 19:47
illright
illright requested changes Jul 14, 2024
View reviewed changes
Copy link
Member

@illright illright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic job! I'm very happy that you did all the steps that are needed to add a rule. I also like the code of the rule, it's short and to the point.

I've left some suggestions, mostly around the error messages, as that is the most important part of a rule. Let me know what you think about them

packages/steiger-plugin-fsd/src/no-segments-on-sliced-layers/README.md Outdated Show resolved Hide resolved
packages/steiger-plugin-fsd/src/no-segments-on-sliced-layers/index.ts Outdated Show resolved Hide resolved
packages/steiger-plugin-fsd/src/no-segments-on-sliced-layers/index.ts Outdated Show resolved Hide resolved
packages/steiger-plugin-fsd/src/no-segments-on-sliced-layers/index.spec.ts Outdated Show resolved Hide resolved
@daniilsapa
Copy link
Collaborator Author

Thanks for your feedback! I'm glad to bring value to the project. 
I agree, your suggestions make perfect sense and improve the solution. I have already corrected the highlighted parts

@daniilsapa daniilsapa requested a review from illright July 15, 2024 11:09
@illright
Copy link
Member

I guess toSorted is not available in Node 18. Could you replace it with .sort()?

@daniilsapa
Copy link
Collaborator Author

Yep, sure

@daniilsapa
Copy link
Collaborator Author

@illright
Done

@illright illright merged commit 5e7fa93 into feature-sliced:master Jul 16, 2024
7 checks passed
@daniilsapa daniilsapa deleted the feature/no-segments-on-sliced-layers branch July 18, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illright illright illright approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement no-segments-on-sliced-layers
2 participants
@daniilsapa @illright