Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ios warnings #391

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix ios warnings #391

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
906b16a
handle case wher FIRApp is already configured
Oct 13, 2017
019201b
removed unused variable in didReceiveRemoteNotification
Oct 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/ios/AppDelegate+FCMPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,9 @@ - (BOOL)application:(UIApplication *)application customDidFinishLaunchingWithOpt
}

// [START configure_firebase]
[FIRApp configure];
if([FIRApp defaultApp] == nil)
[FIRApp configure];

// [END configure_firebase]
// Add observer for InstanceID token refresh callback.
[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(tokenRefreshNotification:)
Expand Down Expand Up @@ -223,8 +225,8 @@ - (void)application:(UIApplication *)application didReceiveRemoteNotification:(N
// foreground (user taps notification)

UIApplicationState state = application.applicationState;
if (application.applicationState == UIApplicationStateActive
|| application.applicationState == UIApplicationStateInactive) {
if (state == UIApplicationStateActive
|| state == UIApplicationStateInactive) {
[userInfoMutable setValue:@(NO) forKey:@"wasTapped"];
NSLog(@"app active");
NSData *jsonData = [NSJSONSerialization dataWithJSONObject:userInfoMutable
Expand Down