Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FCMPlugin.gradle #488

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Xdabier
Copy link

@Xdabier Xdabier commented Mar 30, 2018

as for the last update of google services to version 12 this line
apply plugin: com.google.gms.googleservices.GoogleServicesPlugin
will cause the following build error :
BUILD FAILED Error: more than one library with package name 'com.google.android.gms.license


This change is Reviewable

@macdonst
Copy link

macdonst commented Apr 9, 2018

@Xdabier this is not a good generic solution for the issue. For your case more than one plugin tries to call GoogleServicesPlugin but others using this plugin may not have the same issue and the GoogleServicesPlugin will never be applied.

The better solution would be to use cordova-support-google-services which I will send a PR about shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants