Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type exports and polish fedimint-ts #25

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Conversation

okjodom
Copy link
Contributor

@okjodom okjodom commented Apr 16, 2024

I pulled fedimint-ts v0.2.23 into my repo and got typing errors which I've now fixed. Now proposing we make a patch relese at v0.2.24. Alongside the type changes, I've just polished the lib to be more production like.

ERROR in ../../node_modules/fedimint-ts/FedimintClient.ts 1:12
Module parse failed: Unexpected token (1:12)
File was processed with these loaders:
 * ../../node_modules/source-map-loader/dist/cjs.js
You may need an additional loader to handle the result of these loaders.
> import type {
|   // BackupRequest,
|   InfoResponse,

ERROR in ../../node_modules/fedimint-ts/types.ts 1:0
Module parse failed: The keyword 'interface' is reserved (1:0)
File was processed with these loaders:
 * ../../node_modules/source-map-loader/dist/cjs.js
You may need an additional loader to handle the result of these loaders.
> interface Tiered<T> {
|   [amount: number]: T;
| }

webpack compiled with 2 errors and 11 warnings

@okjodom
Copy link
Contributor Author

okjodom commented Apr 16, 2024

draft because this builds on top of #23 and #24

okjodom added 3 commits April 17, 2024 22:25
- improve type exports to avoid missaps on lib
- refactor dir structure for src/ and test/ clarity
- new lib asset compilation using tsc to dist/
@okjodom okjodom marked this pull request as ready for review April 17, 2024 19:25
@okjodom
Copy link
Contributor Author

okjodom commented Apr 17, 2024

cc @Kodylow

Copy link
Member

@Kodylow Kodylow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, ty

@Kodylow Kodylow merged commit fd11a74 into fedimint:master Apr 17, 2024
10 checks passed
@okjodom okjodom mentioned this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants