chore: move /metrics endpoint to a dedicated port #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensg
force-pushed
the
cliend-metrics-endpoint
branch
4 times, most recently
from
d31668c to
88462b8
Compare
|
@hensg merged dpc's flakebox update, this just needs a rebase ontop then should pass CI and be good to go |
The `/metrics` endpoint was previously exposed on the same port as the public API, which could potentially expose internal monitoring data to external users. Since this endpoint is intended for internal use and Prometheus monitoring, it should not be publicly accessible. This commit introduces a separate server listener for Prometheus metrics, binding it to a dedicated port (default: 127.0.0.1:3001), ensuring that it remains private
Kodylow
force-pushed
the
cliend-metrics-endpoint
branch
from
88462b8 to
46393f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/metricsendpoint was previously exposed on the same port as the public API, which could potentially expose internal monitoring data to external users. Since this endpoint is intended for internal use and Prometheus monitoring, it should not be publicly accessible.This commit introduces a separate server listener for Prometheus metrics, binding it to a dedicated port (default: 127.0.0.1:3001), ensuring that it remains private