Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make dyn bitcoin rpc available in ServerModuleInitArgs #6456

Closed
wants to merge 1 commit into from
Closed

feat: make dyn bitcoin rpc available in ServerModuleInitArgs #6456

wants to merge 1 commit into from

Conversation

joschisan
Copy link
Contributor

No description provided.

@joschisan joschisan requested review from a team as code owners November 25, 2024 05:03
@joschisan joschisan marked this pull request as draft November 25, 2024 05:06
tvolk131
tvolk131 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@tvolk131 tvolk131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactor!

fedimint-core/src/bitcoin_rpc.rs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we moving IBitcoindRpc to fedimint-core to avoid a circular dependency between fedimint-bitcoind and fedimint-core? Or is there another reason? It's strange to separate IBitcoindRpc from IBitcoindRpcFactory, but it sounds like we might be removing IBitcoindRpcFactory anyway.

If we can't keep IBitcoindRpc in fedimint-bitcoind, it might make sense to just merge all of fedimint-bitcoind into fedimint-core. We can see how further refactors play out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I had to move the IBitcoinRpc trait into fedimint core into fedimint core so I can use it in the ServerModuleInitArgs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to turn this into a bigger refactor where at the end we can remove the factory.

@joschisan joschisan closed this Jan 15, 2025
@joschisan joschisan deleted the bitcoin_rpc_refactor branch January 18, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvolk131 tvolk131 tvolk131 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joschisan @tvolk131