Support container logs #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New container_file field added to schemas - serves the same purpose as spec_file, just for containerfiles. - New endpoint for feedbacks for container logs created /frontend/contribute/container - New provider for containers created, fetching only logs from URL for now Fixes #35
- url has to check if header contains text/plain not if it exactly contains it - e.g. paste.centos's raw text contains text/plain; charset=utf-8 as a content - packit provider for whatever reason was checking build_id instead of task_id for packit api
FrostyX
force-pushed
the
container-logs
branch
from
60a9ee1 to
9daa6b0
Compare
jpodivin
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #24
Fix #34
Fix #35
We collaborated on this PR with @nikromen