mark failed gating tests on update list

Signed-off-by: Mattia Verga <[email protected]>

bodhi-server/bodhi/server/templates/comments.html

@@ -6,7 +6,6 @@
 %>
 <%inherit file="${inherit(context)}"/>
 
-<%namespace name="util" module="bodhi.server.util"/>
 <%namespace name="fragments" file="fragments.html"/>
 
 

bodhi-server/bodhi/server/templates/fragments.html

@@ -209,8 +209,15 @@
       <div class="row align-items-center no-gutters">
           <div class="col-md mb-1 mb-md-0">
               <div class="d-flex align-items-center">
-                  <div class="flex-shrink-0">
-                    ${util.type2icon(update['type'])|n}
+                  <div class="flex-column flex-shrink-0">
+                    <div>${util.type2icon(update['type'])|n}</div>
+                    %if update.test_gating_status is not None and update.test_gating_status.value == 'failed':
+                    <div>
+                      <span data-toggle="tooltip" aria-label="This update failed gating tests" data-bs-original-title="This update failed gating tests">
+                        <i class="fa fa-fw fa-heartbeat text-danger"></i>
+                      </span>
+                    </div>
+                    %endif
                   </div>
                   <div class="flex-grow-1 ms-2">
                       <div class="fw-bold">

bodhi-server/bodhi/server/templates/home.html

@@ -1,6 +1,4 @@
 <%inherit file="master.html"/>
-<%namespace name="util" module="bodhi.server.util"/>
-
 
 % if not request.identity:
 <div class="subheader py-5 mb-2">

bodhi-server/bodhi/server/templates/override.html

@@ -1,4 +1,3 @@
-<%namespace name="util" module="bodhi.server.util"/>
 <%inherit file="master.html"/>
 
 <%block name="css">
@@ -85,12 +84,12 @@ <h5 class="fw-bold d-flex align-items-center">
           <div class="form-group">
             %if override is not UNDEFINED:
             <a href="${request.route_url('user', name=override.submitter.name)}">
-              <img src="${util.avatar(override.submitter.name, override.submitter.email, size=24)}" alt="User Icon"/>
+              <img src="${self.util.avatar(override.submitter.name, override.submitter.email, size=24)}" alt="User Icon"/>
               ${override.submitter.name}
             </a>
             %else:
             <a href="${request.route_url('user', name=request.identity.name)}">
-              <img src="${util.avatar(request.identity.name, override.submitter.email, size=24)}" alt="User Icon"/>
+              <img src="${self.util.avatar(request.identity.name, override.submitter.email, size=24)}" alt="User Icon"/>
               ${request.identity.name}
             </a>
             %endif
@@ -103,9 +102,9 @@ <h5 class="fw-bold d-flex align-items-center">
               Expiration date
               %if override:
               % if override['expired_date'] is None:
-              <span class='col-xs-auto pe-2 ms-auto text-success'><small>still active for <strong>${util.age(override['expiration_date'], True)}</strong></small></span>
+              <span class='col-xs-auto pe-2 ms-auto text-success'><small>still active for <strong>${self.util.age(override['expiration_date'], True)}</strong></small></span>
               % else:
-              <span class='col-xs-auto pe-2 ms-auto text-danger'><small>expired <strong>${util.age(override['expired_date'])}</strong></small></span>
+              <span class='col-xs-auto pe-2 ms-auto text-danger'><small>expired <strong>${self.util.age(override['expired_date'])}</strong></small></span>
              % endif
              % endif
           </h5>
@@ -187,7 +186,7 @@ <h5 class="fw-bold d-flex align-items-center">
             </h5>
           <div>
             <a href="${request.route_url('user', name=override.submitter.name)}">
-              <img src="${util.avatar(override.submitter.name, override.submitter.email, size=24)}" alt="User Icon"/>
+              <img src="${self.util.avatar(override.submitter.name, override.submitter.email, size=24)}" alt="User Icon"/>
               ${override.submitter.name}
             </a>
           </div>
@@ -198,9 +197,9 @@ <h5 class="fw-bold d-flex align-items-center">
               Expiration date
               %if override:
               % if override['expired_date'] is None:
-              <span class='col-xs-auto pe-2 ms-auto text-success'><small>still active for <strong>${util.age(override['expiration_date'], True)}</strong></small></span>
+              <span class='col-xs-auto pe-2 ms-auto text-success'><small>still active for <strong>${self.util.age(override['expiration_date'], True)}</strong></small></span>
               % else:
-              <span class='col-xs-auto pe-2 ms-auto text-danger'><small>expired <strong>${util.age(override['expired_date'])}</strong></small></span>
+              <span class='col-xs-auto pe-2 ms-auto text-danger'><small>expired <strong>${self.util.age(override['expired_date'])}</strong></small></span>
              % endif
              % endif
           </h5>

bodhi-server/bodhi/server/templates/update.html

@@ -5,8 +5,6 @@
 
   from bodhi.server import models
 
-  from bodhi.server.config import config
-
   install_command = update.install_command
 %>
 
@@ -42,7 +40,7 @@
       actions['unpush'] = True
       if update.meets_testing_requirements and not update.request:
         actions['push to stable'] = True
-elif can_edit and update.status.value == 'testing' and update.test_gating_status.value == 'failed':
+elif can_edit and update.status.value == 'testing' and update.test_gating_status == models.TestGatingStatus.failed:
   actions['unpush'] = True
 %>
 <div class="subheader pt-3">

news/PR5852.feature

@@ -0,0 +1 @@
+bodhi-server: Updates which fail gating tests are now marked by an icon in the update list view