Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

00443: gh-124651: Quote template strings in venv activation scripts #89

Merged
merged 1 commit into from
Nov 5, 2024
Merged

00443: gh-124651: Quote template strings in venv activation scripts #89

merged 1 commit into from
Nov 5, 2024

Conversation

frenzymadness
Copy link
Member

(cherry picked from 3.9)

Patch backported from python#126301 by @vstinner

Victor, you have most of the context for a review of my backport to 3.6.

@frenzymadness
Copy link
Member Author

I have a reproducer for the problem based on the original report. The original report is:

envname='";uname -a;"'
mkdir "$envname"
cd "$envname"
python3 -m venv .
. ./bin/activate

This patch fixes the problem.

Scratch build with the patch: https://koji.fedoraproject.org/koji/taskinfo?taskID=125509295

vstinner
vstinner approved these changes Nov 5, 2024
View reviewed changes
Copy link

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frenzymadness frenzymadness merged commit f20031e into fedora-python:fedora-3.6 Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frenzymadness @vstinner