Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: fix crash when any webserver dependency is not installed #877

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

cosven
Copy link
Member

@cosven cosven commented Nov 6, 2024

Before, when a user enables webserver and does not install sanic, the app just crashes.
Now, log a error message instead.
telegram-cloud-photo-size-5-6150136853269953860-y

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11700931732

Details

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.009%) to 55.375%

Changes Missing Coverage Covered Lines Changed/Added Lines %
feeluown/app/server_app.py 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
feeluown/app/server_app.py 1 70.59%
Totals Coverage Status
Change from base Build 11546214442: -0.009%
Covered Lines: 9983
Relevant Lines: 18028

💛 - Coveralls

@cosven cosven merged commit 63934aa into feeluown:master Nov 6, 2024
7 of 9 checks passed
@cosven cosven deleted the fix-webserver branch November 6, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants