-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: improve equality comparison performance #173
Merged
felangel
merged 17 commits into
felangel:master
from
Maksimka101:feat/performance-improvement
Nov 21, 2024
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
991cebf
Feat: improve comparison performance
Maksimka101 6204491
Feat: optimize non collection properties comparison
Maksimka101 45a0377
Refactor: move comparison logic back to the `equatable_utils.dart` file
Maksimka101 88052e1
Fix: sets comparison
Maksimka101 312a2a8
Style: reformat code
Maksimka101 c3f4aef
Fix: sets comparison in the `_objectsEquals` function
Maksimka101 725f521
refactor: minor updates to code consistency
felangel b21514f
Merge branch 'master' into feat/performance-improvement
felangel 8d283b0
refactor: simplify `equals` implementation and fix coverage
felangel 6ab28df
chore: update benchmarks
felangel fed7e05
chore: adjust comments
felangel 3f5afff
refactor: simplify equatable utils
felangel 261a28b
Fix the `setEquals` function and write tests for the `*Equals` functions
Maksimka101 751a2b0
Inline the `_isEquatable` and `objectsEquals` functions to improve pe…
Maksimka101 29e6c77
Merge branch 'master' into feat/performance-improvement
felangel bed68af
chore: update benchmark results
felangel 9e0983b
chore: minor adjustments
felangel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on calling
setEquals
instead of asserting here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't expect anyone to use this function. I'm not sure it's even exported. So I'd prefer to leave it simple, without extra ifs