Allow the library to be used in -fno-exception targets #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khng300
force-pushed
the
throw-helper
branch
from
1946a0c to
9e48ebb
Compare
khng300
force-pushed
the
throw-helper
branch
2 times, most recently
from
379a6d6 to
416d876
Compare
This change introduces cista::throw_exception as a helper to dispatch the call to either a throw expression, or abort() call in case -fno-exception is enabled.
khng300
force-pushed
the
throw-helper
branch
from
416d876 to
d145305
Compare
|
I just force-pushed with no changes but seems like the review view of include/cista/cista_exception.h is still not updated. |
|
Thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces cista::throw_exception as a helper to dispatch the call to either a throw expression, or abort() call in case -fno-exception is enabled.