Fixed bug when jemoji is included via module-info.java #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear felldo,
first of all, let me say that this is really a great library! It is exactly what I was looking for.
It tried to include JEmoji into my java project where I use module-info.java. However, several functions such as
EmojiManager.getAllEmojis()
throw an exception (see below). emojitest.tar.gz contains an example project which will reproduce the error .The reason is that
readFileAsString
cannot load the ressource-path PATH by means ofclassLoader.getResourceAsStream(PATH)
. According to stackeroverflow.com one should useEmojiManager.class.getResourceAsStream(PATH)
instead. This is the content of the PR.It would be great if you could merge my PR.
Best regards,
Michael
Error message:
------------------------------------------snip------------------------------------------
Exception in thread "main" java.lang.ExceptionInInitializerError
at test/test.Program.main(Program.java:11)
Caused by: java.lang.IllegalArgumentException: argument "content" is null
at [email protected]/com.fasterxml.jackson.databind.ObjectMapper._assertNotNull(ObjectMapper.java:5054)
at [email protected]/com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3828)
at net.fellbaum.jemoji/net.fellbaum.jemoji.EmojiManager.(EmojiManager.java:38)
... 1 more
------------------------------------------snap------------------------------------------