Change remove excess Cube.create method

README.md

@@ -127,7 +127,7 @@ let dimensionHierarchies = [
 ];
 
 // We send it all to the constructor
-let cube = Cube.create(dimensionHierarchies);
+let cube = new Cube({dimensionHierarchies});
 cube.addFacts(facts);
 
 ```
@@ -457,7 +457,7 @@ let facts = [
     { id: 1, product: 'TV', mark: 'Sony', country: 'China', count: 2 },
     { id: 1, product: 'TV', mark: 'Samsung', country: 'Niderland', count: 3 }
 ];
-let cube = Cube.create();
+let cube = new Cube();
 cube.addFacts(facts);
 cube.addDimensionHierarchy({
     dimensionTable: {
@@ -507,7 +507,7 @@ let facts = [
     { id: 1, region: 'North', product: 'Product 1', value: 10 },
     { id: 2, region: 'South', product: 'Product 2', value: 20 }
 ];
-let cube = Cube.create(dimensionHierarchies);
+let cube = new Cube({dimensionHierarchies});
 cube.addFacts(facts);
 
 ```
@@ -582,7 +582,7 @@ let dimensionHierarchies = [
        }
    }
 ]
-let cube = Cube.create(dimensionHierarchies)
+let cube = new Cube({dimensionHierarchies})
 cube.addFacts(facts);
 let members = cube.getDimensionMembers('user')
 ```
@@ -615,7 +615,7 @@ let dimensionHierarchies = [
         ]
     }
 ];
-let cube = Cube.create(dimensionHierarchies);
+let cube = new Cube({dimensionHierarchies});
 cube.addFacts(facts);
 
 ```
@@ -657,7 +657,7 @@ let dimensionHierarchies = [
         }
     }
 ];
-let cube = Cube.create(dimensionHierarchies)
+let cube = new Cube({dimensionHierarchies})
 cube.addDimensionMember('user')
 ```
 ### Custom facts
@@ -679,7 +679,7 @@ let dimensionHierarchies = [
 let options = {
     factPrimaryKey: 'saleId'
 }
-let cube = Cube.create(dimensionHierarchies, options)
+let cube = new Cube({dimensionHierarchies, ...options})
 cube.addFacts(facts);
 
 ```
@@ -711,7 +711,7 @@ let options = {
         isOpen: false
     }
 }
-let cube = Cube.create(dimensionHierarchies, options);
+let cube = new Cube({dimensionHierarchies, ...options});
 cube.addFacts(facts);
 cube.fillEmptyCells();
 cube.addDimensionMember('x', { x: 3 })

spec/data/products.js

@@ -56,7 +56,7 @@ const dimensionHierarchies = [
 ];
 
 export function createProductCube() {
-	const cube = Cube.create(dimensionHierarchies);
+	const cube = new Cube({dimensionHierarchies});
 	cube.addFacts(factTable);
 	return cube;
 }

src/Cube.defaultFactOptions.spec.js

@@ -8,5 +8,7 @@ export default () => {
 			&& typeof cube.defaultFactOptions === 'object'
 		).toBe(true)
 	});
-	xit('add inevitability of defaultFactOptions property')
+	xit('add inevitability for defaultFactOptions property', () => {
+
+	})
 };

src/Cube.factPrimaryKey.spec.js

@@ -29,7 +29,7 @@ export default () => {
 			{ id: 1, direction: 'left', date: '01' },
 			{ id: 2, direction: 'right', date: '02' },
 		];
-		cube = Cube.create(dimensionHierarchies, options);
+		cube = new Cube({dimensionHierarchies, ...options});
 		cube.addFacts(factTable);
 		expect(cube.factPrimaryKey === 'id').toBe(true);
 	});
@@ -40,7 +40,7 @@ export default () => {
 				{ direction: 'left', date: '01' },
 				{ direction: 'right', date: '02' },
 			];
-			cube = Cube.create(dimensionHierarchies);
+			cube = new Cube({dimensionHierarchies});
 			cube.addFacts(factTable);
 		}).toThrow();
 	});
@@ -52,7 +52,7 @@ export default () => {
 			{ direction: 'right', date: '02' },
 		];
 		try {
-			cube = Cube.create(dimensionHierarchies);
+			cube = new Cube({dimensionHierarchies});
 			cube.addFacts(factTable);
 		} catch (error) {
 			err = error
@@ -68,7 +68,7 @@ export default () => {
 		options = {
 			factPrimaryKey: 'factId'
 		};
-		cube = Cube.create(dimensionHierarchies, options);
+		cube = new Cube({dimensionHierarchies, ...options});
 		cube.addFacts(factTable);
 		expect(cube.getCells()[0]["factId"]).toBeDefined();
 		isEqualObjects(cube.getFacts(), factTable);

src/Cube.js

@@ -5,7 +5,6 @@ import DimensionHierarchy from './DimensionHierarchy.js'
 import DimensionTable from './DimensionTable.js'
 import {
 	InsufficientRollupData,
-	CreateInstanceException
 } from './errors.js';
 import SnowflakeBuilder from './SnowflakeBuilder.js'
 import console from './console.js'
@@ -79,33 +78,6 @@ class Cube {
 		// 	console.warn('Fact table has residuals', residuals)
 		// }
 	}
-	/**
-	 * @public
-	 * Fabric method for creating cube from facts and dimensionHierarchiesData data
-	 * analogy to the construction of such a call:
-	 *      (new Cube(dimensionHierarchiesData)).addFacts(factTable)
-	 *
-	 * @param {Object[]} dimensionHierarchies
-	 * @param {Object} options
-	 * @return {Cube}
-	 * @throw {TypeError}
-	 * */
-	static create(dimensionHierarchies = [], options) {
-		if (!Array.isArray(dimensionHierarchies)){
-			throw TypeError("The first argument must be an array")
-		}
-
-		if (!(Cube.isPrototypeOf(this) || Cube === this)) {
-			throw new CreateInstanceException()
-		}
-
-		const cube = new this({
-			...options,
-			dimensionHierarchies: dimensionHierarchies,
-		});
-
-		return cube;
-	}
 	/**
 	 * is the act of picking a rectangular subset of a cube by choosing a single value
 	 * for one of its dimensions, creating a new cube with one fewer dimension.

src/Cube.prototype.addDimensionHierarchy.spec.js

@@ -23,7 +23,7 @@ export default () => {
 				{ id: 1, x_id: 1 },
 				{ id: 2, x_id: 2 }
 			];
-			cube = Cube.create();
+			cube = new Cube();
 			cube.addFacts(facts);
 
 			addDimensionHierarchy = () => {
@@ -58,7 +58,7 @@ export default () => {
 				{ id: 1, x_id: 1 },
 				{ id: 2, x_id: 2 }
 			];
-			cube = Cube.create();
+			cube = new Cube();
 			cube.addFacts(facts);
 
 			addDimensionHierarchy = () => {

src/Cube.prototype.addDimensionMember.spec.js

@@ -50,7 +50,7 @@ export default () => {
 				{ id: 1, x: 0, xx: 0, xxx: 0 , xxxx: 0, z: 0 },
 			];
 
-			cube = Cube.create(dimensionHierarchies);
+			cube = new Cube({dimensionHierarchies});
 			cube.addFacts(factTable);
 
 		});
@@ -137,7 +137,7 @@ export default () => {
 				}
 			];
 
-			cube = Cube.create(dimensionHierarchies);
+			cube = new Cube({dimensionHierarchies});
 			cube.addFacts(factTable);
 		});
 
@@ -244,7 +244,7 @@ export default () => {
 				{ id: 4, product: 'telephone', category: 'electronic', money: '15$', year: '2018', month: 'january', day: 3 }
 			];
 
-			cube = Cube.create(dimensionHierarchies);
+			cube = new Cube({dimensionHierarchies});
 			cube.addFacts(factTable);
 			// todo need fill before add, because actually getFacts method invoke fill method inside, need some to do with this
 			cube.fillEmptyCells();

src/Cube.prototype.addEmptyCells.spec.js

@@ -28,7 +28,7 @@ export default () => {
 				}
 			}
 		];
-		cube = Cube.create(dimensionHierarchies);
+		cube = new Cube({dimensionHierarchies});
 		cube.addFacts(factTable);
 	});
 

src/Cube.prototype.createEmptyCells.spec.js

@@ -28,7 +28,7 @@ export default () => {
 				{ dimensionTable: { dimension: 'y', keyProps: ['y'] }},
 				{ dimensionTable: { dimension: 'z', keyProps: ['z'] }}
 			];
-			cube = Cube.create(dimensionHierarchies);
+			cube = new Cube({dimensionHierarchies});
 			cube.addFacts(factTable);
 		});
 
@@ -91,7 +91,7 @@ export default () => {
 					isOpen: expectedValue
 				}
 			};
-			const cube = Cube.create(dimensionHierarchies, options);
+			const cube = new Cube({dimensionHierarchies, ...options});
 			cube.addFacts(factTable);
 			const emptyCells = cube.createEmptyCells();
 
@@ -128,7 +128,7 @@ export default () => {
 			}
 		};
 		const expectedCountValue = 100;
-		const cube = Cube.create(dimensionHierarchies, options);
+		const cube = new Cube({dimensionHierarchies, ...options});
 		cube.addFacts(factTable);
 		const emptyCells = cube.createEmptyCells({count: expectedCountValue});
 		emptyCells.forEach(emptyCell => {
@@ -164,7 +164,7 @@ export default () => {
 			}
 		}
 		const expectedValue = 'some value';
-		const cube = Cube.create(dimensionHierarchies, options);
+		const cube = new Cube({dimensionHierarchies, ...options});
 		cube.addFacts(factTable);
 		const emptyCells = cube.createEmptyCells({ x_id: expectedValue });
 		emptyCells.forEach(emptyCell => {

src/Cube.prototype.dice.spec.js

@@ -33,7 +33,7 @@ export default () => {
 				},
 			}
 		];
-		cube = Cube.create(dimensionHierarchies);
+		cube = new Cube({dimensionHierarchies});
 		cube.addFacts(facts);
 	});
 	it('should define dice', () => {

src/Cube.prototype.drillUpAndDown.spec.js

@@ -41,15 +41,15 @@ export default () => {
 	});
 
 	it('drillUp ', () => {
-		cube = Cube.create(dimensionHierarchies);
+		cube = new Cube({dimensionHierarchies});
 		cube.addFacts(facts);
 		expect(debug = cube.dimensionHierarchies[0].activeDimension === 'name');
 		cube.drillUp('humans', 'group');
 		expect(debug = cube.dimensionHierarchies[0].activeDimension === 'group').toBe(true)
 	});
 	it('drillDown', () => {
 		dimensionHierarchies[0].activeDimension = 'group';
-		cube = Cube.create(dimensionHierarchies);
+		cube = new Cube({dimensionHierarchies});
 		cube.addFacts(facts);
 		expect(debug = cube.dimensionHierarchies[0].activeDimension === 'group');
 		cube.drillDown('humans', 'name');

src/Cube.prototype.fillEmptyCells.spec.js

@@ -26,7 +26,7 @@ export default () => {
 	});
 
 	it('should normalize count of cells for non-normalized data', () => {
-		let cube = Cube.create(dimensionHierarchies);
+		let cube = new Cube({dimensionHierarchies});
 		cube.addFacts(factTable);
 		expect(debug = Cube.cartesian(cube).length).toBe(8);
 		expect(debug = cube.getFacts().length).toBe(5);
@@ -36,7 +36,7 @@ export default () => {
 	});
 
 	it('should normalize count of cells for non-normalized data with default props', () => {
-		let cube = Cube.create(dimensionHierarchies);
+		let cube = new Cube({dimensionHierarchies});
 		cube.addFacts(factTable);
 
 		cube.fillEmptyCells({ is: false });
@@ -92,7 +92,7 @@ export default () => {
 				{ id: 2, humans: 5, city: 'Paris', nationality: 'French', country: 'France', planet: 'Earth' },
 			];
 
-			const cube = Cube.create(dimensionHierarchies);
+			const cube = new Cube({dimensionHierarchies});
 			cube.addFacts(factTable);
 
 			expect(debug = Cube.cartesian(cube).length).toBe(4);
@@ -109,7 +109,7 @@ export default () => {
 				{ id: 3, humans: 1, city: 'Paris', nationality: 'French', country: 'France', planet: 'Mars' },
 			];
 
-			const cube = Cube.create(dimensionHierarchies);
+			const cube = new Cube({dimensionHierarchies});
 			cube.addFacts(factTable);
 
 			expect(debug = Cube.cartesian(cube).length).toBe(6);
@@ -139,7 +139,7 @@ export default () => {
 			{ id: 1, x: 0, y: 1, xy: true },
 			{ id: 2, x: 1, y: 0, xy: true }
 		];
-		const cube = Cube.create(dimensionHierarchies);
+		const cube = new Cube({dimensionHierarchies});
 		cube.addFacts(factTable);
 
 		cube.fillEmptyCells({ xy: false });

src/Cube.prototype.getEmptyCells.spec.js

@@ -28,7 +28,7 @@ export default () => {
 				}
 			}
 		];
-		cube = Cube.create(dimensionHierarchies);
+		cube = new Cube({dimensionHierarchies});
 		cube.addFacts(factTable);
 	});
 

src/Cube.prototype.removeDimensionHierarchy.spec.js

@@ -22,14 +22,15 @@ export default () => {
 			{ id: 1, x_id: 1 },
 			{ id: 2, x_id: 2 }
 		];
-		cube = Cube.create([
+		const dimensionHierarchies = [
 			{
 				dimensionTable: {
 					dimension: 'x',
 					keyProps: ['x']
 				}
 			}
-		]);
+		];
+		cube = new Cube({dimensionHierarchies});
 		cube.addFacts(facts);
 		removeDimensionHierarchy = () => {
 			cube.removeDimensionHierarchy(cube.dimensionHierarchies[0]);

src/Cube.prototype.removeDimensionMember.spec.js

@@ -56,7 +56,7 @@ export default () => {
 				]
 			}
 		];
-		cube = Cube.create(dimensionHierarchies);
+		cube = new Cube({dimensionHierarchies});
 		cube.addFacts(factTable);
 	});
 

src/Cube.prototype.slice.spec.js

@@ -34,7 +34,7 @@ export default () => {
 				},
 			}
 		];
-		cube = Cube.create(dimensionHierarchies);
+		cube = new Cube({dimensionHierarchies});
 		cube.addFacts(facts);
 	});
 	it('should define slice', () => {