Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google-calendar recipe to load external scripts to fix CSP error #402

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

vraravam
Copy link
Contributor

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

Based on https://github.com/ferdium/ferdium-app/issues/1086\#issuecomment-1656926137, fixed google calendar recipe to load the external css.

@vraravam vraravam requested review from mcmxcdev and a team July 30, 2023 09:43
@vraravam vraravam self-assigned this Jul 30, 2023
@mcmxcdev
Copy link
Contributor

mcmxcdev commented Jul 30, 2023

Veriified locally that it works:

  • went to /recipes folder inside ferdium-app and applied the same changes as here
  • ran pnpm package in recipes folder
  • started ferdium-app locally with pnpm debug
  • waited until I was told that services have been updated by prompt
  • reloaded google-calendar service and dark mode works again

image


I think though that dark mode is always on now with how its set up. We would need to do something like in https://github.com/ferdium/ferdium-recipes/blob/main/recipes/android-messages/webview.js#L43-L47 I assume to be able to toggle it.

@mcmxcdev
Copy link
Contributor

mcmxcdev commented Aug 8, 2023

I updated the code to be able to toggle between rather than always have dark mode enforced in 23bf649 (#402)

Also verified that the correct theme mode is chosen initially when reloading the service (tested once with dark mode enabled, once disabled)

Here is a video showcasing it working:

Screencast.from.2023-08-07.19-28-35.webm

@vraravam vraravam merged commit 6770f56 into ferdium:main Aug 8, 2023
2 checks passed
@vraravam vraravam deleted the fix-1086 branch August 8, 2023 01:41
@lukassr
Copy link
Contributor

lukassr commented Nov 9, 2023

It is important to note that, if enabling Dark Mode in an existing Google Calendar service does not work, you may need to delete it and create a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants