Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case correctly where the 'icon.svg' file isn't present #550

Merged
merged 1 commit into from
May 19, 2024

Conversation

vraravam
Copy link
Contributor

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

  1. Minor refactoring to use consistent fs.existsSync for files.
  2. Also, fixed a bug where, if the icon.svg file was missing, the packaging step would error out.

@vraravam vraravam self-assigned this May 19, 2024
@vraravam vraravam requested a review from a team May 19, 2024 01:27
@vraravam vraravam merged commit dd668a6 into ferdium:main May 19, 2024
2 checks passed
@vraravam vraravam deleted the minor-refactoring branch May 19, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant