Normalize path in pkgJsonRelative before comparing #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vraravam
approved these changes
May 24, 2024
|
@all-contributors please add @Shampra for code |
|
I've put up a pull request to add @Shampra! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
As explain in this issue, we cannot validate PR for recipes because
pnpm validateis still a failure.Script compare the list of detected change where path are like "recipes/hangoutschat/package.json" and pkgJsonRelative contaning path to package.json with this format "recipes\hangoutschat\package.json".
Of course, it never match.
Change : add path normalization on pkgJsonRelative