Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change request shape test to reflect removal of base #36

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

rylev
Copy link
Collaborator

@rylev rylev commented Aug 23, 2024

The only question I have is if we should keep the "spin-base-path" header which is now just hardcoded to "/".

This will likely be removed in Spin 4, but we keep around to aid in the transition from Spin 2 to 3.

@rylev rylev requested a review from lann August 23, 2024 10:15
@rylev rylev merged commit f00b59c into main Aug 26, 2024
2 checks passed
@rylev rylev deleted the base-changes branch August 26, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant