Factors redis trigger #2750
Factors redis trigger #2750
Conversation
| use tracing::{instrument, Level}; | ||
|
|
||
| use crate::spin::SpinRedisExecutor; | ||
| pub struct RedisTrigger; |
There was a problem hiding this comment.
Nit: can we do the _priv: () trick here?
| }) | ||
| type CliArgs = NoCliArgs; | ||
|
|
||
| type InstanceState = (); |
There was a problem hiding this comment.
Random thought: I like how type CliArgs = NoCliArgs; reads much better than type InstanceState = ();. Perhaps we should consider a NoInstanceState type which could be used for empty instance state instead of ().
There was a problem hiding this comment.
fwiw NoCliArgs is only necessary because of the type CliArgs: clap::Args bound.
| let mut pubsub = client | ||
| .get_async_connection() | ||
| ) -> anyhow::Result<Self> { | ||
| let client = Client::open(address)?; |
There was a problem hiding this comment.
Is there a reason to open the client connection here instead of in run_listener?
There was a problem hiding this comment.
open is a lie - its just parsing the address
Signed-off-by: Lann Martin <[email protected]>
Signed-off-by: Lann Martin <[email protected]>
rylev
force-pushed
the
factors-redis-trigger
branch
from
ee57c81
to
381bd80
Compare
|
@lann I rebased this and am going to merge since we have some other changes that move lots of files around, and it'll be easier on everyone if we just get this one in. |
No description provided.