Update rdbms-types to support Date / Tmestamp #2865
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Purpose of this PR is to add datetime and timestamp support. Signed-off-by: tyler-harpool <[email protected]>
rylev
requested changes
Sep 25, 2024
There was a problem hiding this comment.
Thanks for the PR! Adding this will constitute a breaking change so we'll need to make sure we do accept this at the right time. We're figuring out what changes to land in Spin 3.0 so this will definitely be a good candidate for discussion. In the meantime, we appreciate your patience while the discussion happens.
|
Note this will also require updating the conversion routines in the MySQL and Postgres factors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR is to add datetime and timestamp support.