(fix): improve error messages from url parsing (#649)

fern-api · Apr 16, 2024 · 79c90f4 · 79c90f4
1 parent d692efe
commit 79c90f4
Showing 1 changed file with 15 additions and 8 deletions.
diff --git a/servers/fdr/src/util/ParsedBaseUrl.ts b/servers/fdr/src/util/ParsedBaseUrl.ts
@@ -1,3 +1,5 @@
+import { LOGGER } from "../app/FdrApplication";
+
 const HAS_HTTPS_REGEX = /^https?:\/\//i;
 
 export class ParsedBaseUrl {
@@ -21,14 +23,19 @@ export class ParsedBaseUrl {
     }
 
     public static parse(url: string): ParsedBaseUrl {
-        let urlWithHttpsPrefix = url;
-        if (!HAS_HTTPS_REGEX.test(url)) {
-            urlWithHttpsPrefix = "https://" + url;
+        try {
+            let urlWithHttpsPrefix = url;
+            if (!HAS_HTTPS_REGEX.test(url)) {
+                urlWithHttpsPrefix = "https://" + url;
+            }
+            const parsedURL = new URL(urlWithHttpsPrefix);
+            return new ParsedBaseUrl({
+                hostname: parsedURL.hostname,
+                path: parsedURL.pathname === "/" || parsedURL.pathname === "" ? undefined : parsedURL.pathname,
+            });
+        } catch (e) {
+            LOGGER.error(`Failed to parse URL: ${url}`, e);
+            throw new Error(`Failed to parse URL: ${url}. The error was ${(e as Error)?.message}`);
         }
-        const parsedURL = new URL(urlWithHttpsPrefix);
-        return new ParsedBaseUrl({
-            hostname: parsedURL.hostname,
-            path: parsedURL.pathname === "/" || parsedURL.pathname === "" ? undefined : parsedURL.pathname,
-        });
     }
 }