Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: audience mdx component #1630

Merged
merged 1 commit into from
Oct 10, 2024
Merged

feat: audience mdx component #1630

merged 1 commit into from
Oct 10, 2024

Conversation

abvthecity
Copy link
Contributor

@abvthecity abvthecity commented Oct 10, 2024 •
edited
Loading

Introduces the following component:

<Audience audience="a">
> only users in group a can see this content
</Audience>
<Audience audience={["a", "b"]}>
> only users in group a OR b can see this content
</Audience>
<Audience not audience="a">
> users in group a will NOT be able to see this content
</Audience>

@abvthecity abvthecity marked this pull request as ready for review October 10, 2024 05:46
@abvthecity abvthecity enabled auto-merge (squash) October 10, 2024 05:48
@github-actions GitHub Actions
Copy link

Playwright test results

passed  1 passed

Details

stats  1 test across 1 suite
duration  9 seconds
commit  7780f87

@github-actions GitHub Actions
Copy link

PR Preview

@github-actions GitHub Actions
Copy link

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 162.62 KB (🟢 -94.66 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/404 332 B 162.95 KB 46.56%

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/dynamic/[host]/[[...slug]] 55.57 KB 218.19 KB 62.34% (🟢 -6.16%)
/static/[host]/[[...slug]] 55.57 KB 218.19 KB 62.34% (🟢 -6.16%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@github-actions GitHub Actions
Copy link

Playwright test results

passed  81 passed

Details

stats  81 tests across 3 suites
duration  1 minute, 11 seconds
commit  7780f87

@abvthecity abvthecity merged commit dc8d75d into main Oct 10, 2024
20 checks passed
@abvthecity abvthecity deleted the ajiang/audience-component branch October 10, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsinghvi dsinghvi dsinghvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abvthecity @dsinghvi