Use TextDecoder for toString('utf8') #286
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #268
This uses TextDecoder for
toString('utf8')
andtoString()
.I needed to update some tests so that they are in line with Node's native
Buffer
(which also makes them pass withTextDecoder
), I hope this was correct?Technically, it also supports latin1, utf-16le, but the conversion is different from Node for strings that aren't representable in these encodings:
latin1:
utf16: (TextDecoder adds an "�" at the end. https://www.compart.com/en/unicode/U+FFFD)