Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove standard from tests, prefer node testing for first-pass CI #332

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

dcousens
Copy link
Collaborator

@dcousens dcousens commented Oct 8, 2023

Follow up to #331

standard was in the test target, which I think is misleading when we can differentiate that in the GitHub pull requests using workflows (as I did in #331).

Additionally, our default test should prioritise node for now, until I can update the CI with an alternative to airtap (or at least, fix airtap) for browser testing (our primary priority and userbase).

@dcousens dcousens mentioned this pull request Oct 8, 2023
@dcousens dcousens marked this pull request as ready for review January 23, 2024 10:50
@dcousens dcousens self-assigned this Jan 23, 2024
@dcousens dcousens merged commit 067fb90 into master Jan 23, 2024
4 of 5 checks passed
@dcousens dcousens deleted the new-ci branch January 23, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant