Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply patches from #280 and #281 #334

Merged
merged 3 commits into from
Oct 14, 2023
Merged

Apply patches from #280 and #281 #334

merged 3 commits into from
Oct 14, 2023

Commits on Oct 14, 2023

  1. Update local testing commands 

    They're out of date.
    @chronark @dcousens
    chronark authored and dcousens committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    b693e7e View commit details
    Browse the repository at this point in the history

  2. Fix `write{U}Int{LE,BE} types 

    They should take a BigInt as parameter and return the written bytes as regular number, right?

At least that's what it actually does :)
    @chronark @dcousens
    chronark authored and dcousens committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    7d2f744 View commit details
    Browse the repository at this point in the history

  3. Make offset optional to match node Buffer implementation

    @chronark @dcousens
    chronark authored and dcousens committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    b101620 View commit details
    Browse the repository at this point in the history