Cleaning up nRF52 code #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No more static mut. Plus we have functions that return microseconds, which is what defmt::timestamps really wants.
Also has optional timestamps.
Also regenerated the trace files.
Deploying ferrous-systems-rust-exercises with
|
| Latest commit: |
64b7beb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://42dcaeed.ferrous-systems-rust-exercises.pages.dev |
| Branch Preview URL: | https://fix-static-mut-again.ferrous-systems-rust-exercises.pages.dev |
Currently it operates a USB Serial port.
jonathanpallant
force-pushed
the
fix-static-mut-again
branch
from
4f58f6d to
9d7a18a
Compare
) Tested HID channel change. ) Tested USB Serial interface ) Tested radio loopback. Just needs changing to run on the dongle and not the DK.
|
I ported both puzzle-fw and loopback-fw to use RTIC. So now we have no more sketchy |
This was referenced Dec 12, 2024
Closed
listochkin
approved these changes
Dec 12, 2024
Tested on macOS 15, Windows 10 and Debian 12.
jonathanpallant
force-pushed
the
fix-static-mut-again
branch
from
14655c0 to
7e0a25e
Compare
The usb_device is only used in the ISR, so it can be a local. Saves us a lock.
jonathanpallant
force-pushed
the
fix-static-mut-again
branch
from
7e0a25e to
64b7beb
Compare
|
I fixed the build error (I was looking for a file that only existed in some intermediate version) and squashed that and some other fixes. Then I spotted clippy was having opinions, so I cleaned up a few more things. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
static mutdefmt::timestamp!static mutthat 1.83 warned about