Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): verify sync envelope if signed #507

Merged
merged 5 commits into from
Aug 16, 2024
Merged

Conversation

jrriehl
Copy link
Contributor

@jrriehl jrriehl commented Aug 16, 2024

Proposed Changes

A previous update left open the possibility that an envelope sent as a sync response with a signature would not be verified. With this change, we ensure that any envelope that contains a signature gets verified.

Types of changes

What type of change does this pull request make (put an x in the boxes that apply)?

  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Documentation update.
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

Put an x in the boxes that apply:

  • I have read the CONTRIBUTING guide
  • Checks and tests pass locally

@jrriehl jrriehl requested a review from lrahmani as a code owner August 16, 2024 08:00
@jrriehl jrriehl requested review from Archento and removed request for lrahmani August 16, 2024 08:00
@jrriehl jrriehl merged commit 0d30d05 into main Aug 16, 2024
9 checks passed
@jrriehl jrriehl deleted the chore/verify-env-if-signed branch August 16, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants