This repository has been archived by the owner on Nov 24, 2022. It is now read-only.
Add backingstore parameters #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def finalize! | ||
| @sudo_wrapper = nil if @sudo_wrapper == UNSET_VALUE | ||
| @container_name = nil if @container_name == UNSET_VALUE | ||
| @backingstore = "none" if @backingstore == UNSET_VALUE |
There was a problem hiding this comment.
@tailhook I think you forgot to change this to best as you described on the issue. I have already merged this branch locally, changed to 'best' and push back the changes once I'm done with fixing the build.
fgrehm
added a commit
that referenced
this pull request
May 4, 2014
fgrehm
added a commit
that referenced
this pull request
May 13, 2014
fgrehm
added a commit
that referenced
this pull request
May 13, 2014
…none" for old lxc versions [GH-277]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a patch from #235, with cloning support removed.
Also I've set
-B bestby default (the patch in #235 just crashes when no backingstore specified). Let me know if you're not comfortable with this (the lxc by default uses-B dir, butbestis more sensible as it uses btrfs/zfs features if available, and fallbacks todirif not).