Skip to content

Commit

Permalink
Merge branch 'master' into fix_py_versions
Browse files Browse the repository at this point in the history
Signed-off-by: Bernard Kleynhans <[email protected]>
  • Loading branch information
bkleyn authored Sep 5, 2023
2 parents 57fb075 + 6001d64 commit 0751d08
Show file tree
Hide file tree
Showing 20 changed files with 1,854 additions and 209 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ on:
pull_request:
branches:
- master
schedule:
- cron: '00 12 * * 1' # Runs every Monday at 8:00 AM EST

jobs:
Test:
Expand All @@ -28,6 +30,5 @@ jobs:
run: |
python3 -m pip install --upgrade pip
pip install -e .
python3 -m unittest discover -v tests
PYTHONHASHSEED=0 python3 -m unittest discover -v tests
python3 setup.py install
6 changes: 6 additions & 0 deletions CHANGELOG.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
CHANGELOG
=========

-------------------------------------------------------------------------------
April, 24, 2023 1.1.2
-------------------------------------------------------------------------------

- Updated all the test cases to replace experiments on boston housing with california housing data due to deprecation

-------------------------------------------------------------------------------
Feb, 09, 2022 1.1.1
-------------------------------------------------------------------------------
Expand Down
77 changes: 60 additions & 17 deletions README.md

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion feature/_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
# Copyright FMR LLC <[email protected]>
# SPDX-License-Identifier: GNU GPLv3

__version__ = "1.1.1"
__version__ = "1.1.2"
6 changes: 3 additions & 3 deletions feature/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"""

import abc
from typing import NoReturn, Tuple
from typing import NoReturn, Tuple, Union

import numpy as np
import pandas as pd
Expand Down Expand Up @@ -66,12 +66,12 @@ class _BaseSupervisedSelector(_BaseSelector, metaclass=abc.ABCMeta):
"""

@abc.abstractmethod
def fit(self, data: pd.DataFrame, labels: pd.Series) -> NoReturn:
def fit(self, data: pd.DataFrame, labels: Union[pd.Series, pd.DataFrame]) -> NoReturn:
"""Abstract method
Fits the selector to the given data.
"""

def fit_transform(self, data: pd.DataFrame, labels: pd.Series) -> pd.DataFrame:
def fit_transform(self, data: pd.DataFrame, labels: Union[pd.Series, pd.DataFrame]) -> pd.DataFrame:
"""Fits the selector to the given and returns the transformed data.
"""
self.fit(data, labels)
Expand Down
197 changes: 180 additions & 17 deletions feature/selector.py

Large diffs are not rendered by default.

Loading

0 comments on commit 0751d08

Please sign in to comment.