Python versions update #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernard Kleynhans <[email protected]>
skadio
approved these changes
Sep 5, 2023
Signed-off-by: Kleynhans, Bernard <[email protected]>
skadio
approved these changes
Sep 5, 2023
| @@ -13,7 +13,6 @@ | |||
| import numpy as np | |||
| import pandas as pd | |||
| import seaborn as sns | |||
| from catboost import CatBoostClassifier, CatBoostRegressor | |||
There was a problem hiding this comment.
Just for my own learning -- we are dropping CatBoost because it is ? slow? library version complaincy?
Probbaly wanna mention this one in the Changelog
There was a problem hiding this comment.
Just considering it for now. Running into some discrepancies between running tests local vs using GH CI and the Catboost pip installation has been failing on and off. So I'm using GH to easily test across all OS and Python versions (and don't know how to do that without creating PR).
Feel free to ignore PR for now - I will tag you when ready.
There was a problem hiding this comment.
ah cool idea on using GH for testing 👍
skadio
reviewed
Sep 5, 2023
| from tests.test_base import BaseTest | ||
|
|
||
|
|
||
| class TestUtils(BaseTest): |
skadio
approved these changes
Sep 5, 2023
Signed-off-by: Kleynhans, Bernard <[email protected]>
Signed-off-by: Kleynhans, Bernard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.