Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ant-javacard for compilation #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

pepegar
Copy link

@pepegar pepegar commented Nov 21, 2016

Using this plugin cleans A LOT the build.xml file.

Now it's not needed to download the Javacard SDKs globally in your machine, but you can just:

$ git submodule init
$ git submodule update
$ ant

This will produce 2 files, PGP22.cap and PGP30.cap

@miguelcardo
Copy link
Member

That's a great use of resources! 👍 👍 👍 👍 👍
Just one single comment: have you loaded the output CAP file (for example, the JC 2.2.2 one) on a card and briefly tested it? Just that it loads, installs and OpenKeyChain recognizes it as a PGP applet.

<target name="applet">
<javacard>
<cap aid="A0:00:00:06:17:00:EC:5E:FF:D8" output="PGP.cap" sources="applet/src">
<applet class="openpgpcard.OpenPGPApplet" aid="A0:00:00:06:17:00:EC:5E:FF:D8:00:00:00:01:00:00"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are changing the default applet AID. Is this intentional? IIRC gpg is picky about AID-s

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is intentional due to the way our platform handles AIDs: we only allow AIDs composed of:

our RID || application ID assigned to the service provider || custom suffix

We allow exceptions for instance AIDs, but not for ELFs or LMs. A longer explanation is here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants