avoid opening data that was already opened in 3rd party opener #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in other words, if loaded/returned data is IOService.GOVERNING_APP_STARTED it is not shown via uiService.show(data)
|
scijava/scijava-common#430 -- the relevant scijava-common, IOService PR |
|
this became deprecated with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing a drag&drop event, the processing may reach to the stage in which
IOServiceis trying to resolve the incoming data/file.As discussed in scijava-common's PR, sometimes user wants to open the incoming data in own way other than the default
uiService.show().This PR proposes to check the output of the used
IOServiceopener for the newIOService.GOVERNING_APP_STARTED,and if present, no reach out to
uiService.show(data).