Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use replaceState instead of pushState for forms and infolists tab updates #15740

Merged

Conversation

smiliyas
Copy link
Contributor

Description

Closes #15363

This update modifies the tab behavior for forms and infolists to use replaceState instead of pushState. This change prevents unnecessary entries in the browser history, ensuring a smoother user experience when navigating between tabs.

Visual changes

NA

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

… tab updates.

This change updates tab behavior to replace the current URL instead of adding a new entry to the browser history. It prevents creating unnecessary history entries, resulting in a smoother user experience when switching tabs.
@danharrin danharrin added the bug Something isn't working label Mar 2, 2025
@danharrin danharrin added this to the v3 milestone Mar 2, 2025
@danharrin danharrin merged commit b935c84 into filamentphp:3.x Mar 2, 2025
15 checks passed
@smiliyas smiliyas deleted the fix/tabs-navigation-with-query-string branch March 4, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

"Cancel" button on CreateModel page not working when persistTabInQueryString method is present
2 participants