Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subfolder git detection #9

Merged
merged 2 commits into from
Nov 4, 2020
Merged

Fix subfolder git detection #9

merged 2 commits into from
Nov 4, 2020

Conversation

utkarshgupta137
Copy link
Contributor

Use atom's atom.project.repositoryForDirectory to find the repository for a given path.

@utkarshgupta137
Copy link
Contributor Author

@Alhadis

lib/resource.js Outdated Show resolved Hide resolved
lib/resource.js Outdated Show resolved Hide resolved
lib/resource.js Outdated Show resolved Hide resolved
lib/resource.js Outdated Show resolved Hide resolved
@utkarshgupta137
Copy link
Contributor Author

@Alhadis done.

@Alhadis Alhadis merged commit ced554b into file-icons:master Nov 4, 2020
@Alhadis
Copy link
Member

Alhadis commented Nov 4, 2020

@utkarshgupta137 Could you give me an example of the sort of problem you were trying to fix? I'm noticing that repository icons are sporadically disappearing. 🤔

@utkarshgupta137
Copy link
Contributor Author

utkarshgupta137 commented Nov 4, 2020

Same issue as atom/tree-view#1366
It seems that atom and many of its plugins weren't initially designed to handle this.

Anyways, I've not faced any issues.
Note: I've also applied a similar fix to tree-view, so maybe without it, there are issues.

@utkarshgupta137
Copy link
Contributor Author

Hey, if everything looks good, can you release a new version?

@Alhadis
Copy link
Member

Alhadis commented Nov 9, 2020

Your changes broke the package's ability to display repository icons, so, no. 😜

@utkarshgupta137
Copy link
Contributor Author

Can you share an example? I've'nt been able to replicate what you're saying

@Alhadis
Copy link
Member

Alhadis commented Nov 9, 2020

I assume that's because you have tree-view dev-linked to ~/.atom/dev/packages/tree-view. Unlink the package and restart Atom.

@utkarshgupta137
Copy link
Contributor Author

Ah okay. I'll get it merged in tree-view first.

@utkarshgupta137
Copy link
Contributor Author

Hey, I'm not sure when the required commit will get merged in tree-view. Meanwhile, we can keep both old & new logic, so none of the existing functionality is broken?

@Alhadis
Copy link
Member

Alhadis commented Nov 27, 2020

Aye, I'll patch it once I've finished setting up my new MacBook:

Number of days without obsolescence: 1

I took your advice and bought a 16" Intel-powered MacBook Pro, because there's no fucking way I'm waiting half a year for the 16" M1X laptops to drop. Yeah, M1 might be orders of magnitude faster, but to somebody who's been stuck with antique hardware for the last 3 years, anything released within that timespan feels equally fast. 😒

(I'm still trying to reassure myself I did the right thing, so please forgive the rambling monologue...)

@utkarshgupta137
Copy link
Contributor Author

Nice! I am looking at this from the same machine. Do try pock for touch bar.

@Alhadis
Copy link
Member

Alhadis commented Dec 4, 2020

@utkarshgupta137 Would you mind giving the latest changes a whirl? Don't forget to pull from file-icons/atom as well.

@utkarshgupta137
Copy link
Contributor Author

Looks good to me

@Alhadis
Copy link
Member

Alhadis commented Dec 5, 2020

Hey, if everything looks good, can you release a new version?

Done! Released as v0.2.0. 😀 Thanks so much once again for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants