Create a FIP Editor Handbook for current and intending FIP Editors #1101
Conversation
luckyparadise
requested review from
jennijuju,
anorth,
jsoares,
TippyFlitsUK,
momack2 and
rvagg
as code owners
FIP Editor Handbook/README
Outdated
|
|
||
| For pull requests (PRs) that impact **protocol design/specifications** or include **considerations** affecting the protocol: | ||
|
|
||
| - FIP Editors must ensure **at least two appropriate technical reviews and approvals** have been obtained before considering the PR ready to merge. |
There was a problem hiding this comment.
Is the sole difference between these and the ones below the inclusion of "appropriate"? I thought you were going for the "technical".
I'm not sure "appropriate" is well-defined enough for this to make a difference.
| - Be interested in participating in governance. | ||
| - Be skilled in using GitHub. | ||
|
|
||
| Continued inability to meet these requirements may lead to removal from the position. Interested candidates can apply by completing [this form]. Current FIP Editors will review membership requests. |
There was a problem hiding this comment.
Is there a link to the form someone submits? Are we actually going to make and maintain a form? Given how low volume this will be, is it better to create a mailing list (e.g., [email protected]) that contacts all the FIP editors and they handle from there?
There was a problem hiding this comment.
Not even. I think we can just use Slack for this. This document doesn't need to specify a mechanism. If a candidate editor can't figure out how to contact the other editors, they're probably not a fit.
There was a problem hiding this comment.
Thanks for starting this, @luckyparadise. I've made some relatively minor suggestions, and it'll be good to have something like this documented.
| --- | ||
|
|
||
| ## Introduction | ||
| Filecoin Improvement Proposal (FIP) Editors maintain the FIP repository and ensure the editorial completeness of proposals submitted on GitHub. They volunteer their time for the public good, supporting the FIP process by advancing proposals through various stages of their lifecycle. FIP Editors review new proposals, identify formatting and editorial issues, and keep the repository up to date. They leverage their technical expertise to benefit the community by reviewing improvement ideas and providing critical feedback. |
There was a problem hiding this comment.
I suggest adjusting this to highlight that the technical expertise comes from the community.
| Filecoin Improvement Proposal (FIP) Editors maintain the FIP repository and ensure the editorial completeness of proposals submitted on GitHub. They volunteer their time for the public good, supporting the FIP process by advancing proposals through various stages of their lifecycle. FIP Editors review new proposals, identify formatting and editorial issues, and keep the repository up to date. They leverage their technical expertise to benefit the community by reviewing improvement ideas and providing critical feedback. | |
| Filecoin Improvement Proposal (FIP) Editors maintain the FIP repository and ensure the editorial completeness of proposals submitted on GitHub. They volunteer their time for the public good, supporting the FIP process by advancing proposals through various stages of their lifecycle. FIP Editors review new proposals, identify formatting and editorial issues, and keep the repository up to date. They leverage the technical expertise of the community to facilitate the detailed technical, economic, and product review of improvement ideas. FIP Editors may also function as technical reviewers in addition to their facilitation role. |
|
|
||
| ## Membership | ||
|
|
||
| Membership is open to all who wish to apply but is subject to consent by existing FIP Editors. This structure ensures scalable and controlled membership over time. As the process gains stability, existing FIP Editors may decide to make membership more open and less controlled. |
There was a problem hiding this comment.
This would be a change to how we do it now. Membership is currently by invitation and unanimous agreement (or abstention) of the existing editors.
| - Be interested in participating in governance. | ||
| - Be skilled in using GitHub. | ||
|
|
||
| Continued inability to meet these requirements may lead to removal from the position. Interested candidates can apply by completing [this form]. Current FIP Editors will review membership requests. |
There was a problem hiding this comment.
Not even. I think we can just use Slack for this. This document doesn't need to specify a mechanism. If a candidate editor can't figure out how to contact the other editors, they're probably not a fit.
| Candidates should meet the following criteria: | ||
|
|
||
| - Commit **0–5 hours weekly** for reviewing FIPs. | ||
| - Be proficient in English (both written and spoken). | ||
| - Be capable of critiquing proposal concepts. | ||
| - Be familiar with the **Filecoin tech stack**. | ||
| - Have **participated in FIP discussions** (an added advantage). | ||
| - Be interested in participating in governance. | ||
| - Be skilled in using GitHub. |
There was a problem hiding this comment.
I suggest updating this to be more along the lines of if you would like to be invited to become a FIP editor than you should demonstrate these behaviours.
To further expand the roles, responsibilities, and expectations for FIP Editors. I have written a handbook to form an extended guide for current and intending FIP Editors.
Feedback is welcome.