Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements to repro builds with Docker #1607

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Minor improvements to repro builds with Docker #1607

merged 3 commits into from
Jan 28, 2025

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jan 23, 2025

  • exclude target (mine was >40G when I first ran this, not needed for a container build)
  • install rust in the container build so it doesn't need to be done again each time
  • extract common variables in Makefile
  • restore missing all-bundles target
  • make .PHONY readable

@rvagg rvagg requested a review from Stebalien January 23, 2025 05:15
@rvagg rvagg force-pushed the rvagg/id/reproducible-build branch from 1e0315e to bf92dac Compare January 23, 2025 05:39
@rvagg
Copy link
Member Author

rvagg commented Jan 23, 2025

  • Added user switching so the output file is owned by the calling user

@rvagg rvagg mentioned this pull request Jan 23, 2025
Merged
@rvagg rvagg force-pushed the rvagg/id/reproducible-build branch from bf92dac to f18bd03 Compare January 23, 2025 05:54
Stebalien
Stebalien reviewed Jan 23, 2025
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
.dockerignore Show resolved Hide resolved
@Stebalien Stebalien merged commit 62f7ab2 into id/reproducible-build Jan 28, 2025
11 checks passed
@Stebalien Stebalien deleted the rvagg/id/reproducible-build branch January 28, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees

@rvagg rvagg

Labels
None yet
Projects
FilOz
Status: 🎉 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvagg @Stebalien