-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(eth): attach ToFilecoinMessage converter to EthCall type #12062
base: master
Are you sure you want to change the base?
Conversation
All checks have passed |
c538885
to
3d98bd0
Compare
Thanks for the PR! Aarsh will do a pass on it when he is back (he is OOO today). In the meantime, it looks like you need to run: |
Er, sorry, I didn't see the comment from @rjan90. |
Make gen / Make docsgen-cli
Pushed make gen / make doscgen-cli, to unblock this PR (hope that was okay Raul) so that we can merge it. |
Test failure looks real. |
@rjan90 thanks for running make! ❤️ |
Hi @raulk, I'm considering whether it's still worthwhile to finalize this change, or if this PR should get moved back to draft/be closed. I can't recall the specific test that was failing, but it appears to have been resolved, as all checks are currently passing. What do you think? |
👍 this would be a good change; unfortunately things have moved around a bit, the original function being refactored is now in node/impl/eth/utils.go, so this would need a little bit of work. |
I've open a PR with the changes here: #12844. Starting from the master branch seemed to be the simplest approach. |
Small refactor to clean things up.