Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve stalebot behavior/language #12370

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

Stebalien
Copy link
Member

  1. Remove the cutesy language, it's kind of insulting. Happy to revert this change if people feel strongly, but I really don't like it when companies do this kind of thing.
  2. Extend the close delay for both PRs and issues to 72 hours. We don't really need a response within a day and requiring a response within a day is pretty demanding.

1. Remove the cutesy language, it's kind of insulting. Happy to revert
this change if people feel strongly, but I _really_ don't like it when
companies do this kind of thing.
2. Extend the close delay for both PRs and issues to 72 hours. We don't
really need a response within a day and requiring a response within a
day is pretty demanding.
@Stebalien Stebalien requested a review from jennijuju August 9, 2024 16:26
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjan90
Copy link
Contributor

rjan90 commented Aug 9, 2024

Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions

I updated the link here manually, as this linked to the wrong place. We are fixing the link in: #12371

@Stebalien Stebalien changed the title github: improve stalebot behavior/language [skip changelog] ci: improve stalebot behavior/language Aug 9, 2024
@github-actions github-actions bot dismissed their stale review August 9, 2024 18:23

PR title now matches the required format.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjan90 rjan90 added the skip/changelog This change does not require CHANGELOG.md update label Aug 11, 2024
@rjan90 rjan90 changed the title [skip changelog] ci: improve stalebot behavior/language ci: improve stalebot behavior/language Aug 11, 2024
@github-actions github-actions bot dismissed their stale review August 11, 2024 11:17

PR title now matches the required format.

@rjan90
Copy link
Contributor

rjan90 commented Aug 11, 2024

I investigated why this PR failed the "PR Title Check" despite conforming to our conventions. The issue stems from a recent change in our workflow:

  1. We switched from pull_request to pull_request_target to support checking PR titles from forks: fix(ci): support checking forks in PR-title check workflow #12367
  2. This PR was submitted during the transition period.
  3. As a result, two "PR Title Check" workflows are running:
    • The old Check PR Title (pull_request) workflow (now obsolete) is failing.
    • The new pull_request_target workflow is passing.

It's safe to ignore the failing check from the obsolete workflow.

Apologies for the confusion and noise in your PR.

@rjan90 rjan90 merged commit a77342c into master Aug 12, 2024
85 of 86 checks passed
@rjan90 rjan90 deleted the steb/improve-stale-bot branch August 12, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants