-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: improve stalebot behavior/language #12370
Conversation
Stebalien
commented
Aug 9, 2024
- Remove the cutesy language, it's kind of insulting. Happy to revert this change if people feel strongly, but I really don't like it when companies do this kind of thing.
- Extend the close delay for both PRs and issues to 72 hours. We don't really need a response within a day and requiring a response within a day is pretty demanding.
1. Remove the cutesy language, it's kind of insulting. Happy to revert this change if people feel strongly, but I _really_ don't like it when companies do this kind of thing. 2. Extend the close delay for both PRs and issues to 72 hours. We don't really need a response within a day and requiring a response within a day is pretty demanding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
I updated the link here manually, as this linked to the wrong place. We are fixing the link in: #12371 |
PR title now matches the required format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/README.md#pr-title-conventions
PR title now matches the required format.
I investigated why this PR failed the "PR Title Check" despite conforming to our conventions. The issue stems from a recent change in our workflow:
It's safe to ignore the failing check from the obsolete workflow. Apologies for the confusion and noise in your PR. |