feat: implement ticket based F3 participation lease #12531
Merged
+1,774
−850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masih
force-pushed
the
masih/f3-participation-token
branch
6 times, most recently
from
da27be4
to
9316263
Compare
masih
commented
Oct 1, 2024
masih
force-pushed
the
masih/f3-participation-token
branch
3 times, most recently
from
e107151
to
40f1170
Compare
masih
force-pushed
the
masih/f3-participation-token
branch
3 times, most recently
from
bc978d4
to
63a1d03
Compare
masih
changed the title
masih
force-pushed
the
masih/f3-participation-token
branch
from
63a1d03
to
e34e47c
Compare
Kubuxu
reviewed
Oct 3, 2024
|
I think I would like to see the ability of the Miner to set the maximum term of the lease. Fundamentally, the Miner is in control of what they give out. |
masih
force-pushed
the
masih/f3-participation-token
branch
2 times, most recently
from
80b65c0
to
9a3932b
Compare
Added, where the miner sets the validity term, as well as an upper maximum dictated by node for safety. |
masih
force-pushed
the
masih/f3-participation-token
branch
from
9a3932b
to
017d8c3
Compare
Kubuxu
approved these changes
Oct 4, 2024
masih
force-pushed
the
masih/f3-participation-token
branch
from
017d8c3
to
3d12ca5
Compare
Stebalien
requested changes
Oct 4, 2024
67 tasks
masih
force-pushed
the
masih/f3-participation-token
branch
2 times, most recently
from
b36ec70
to
47f6258
Compare
Stebalien
reviewed
Oct 7, 2024
Stebalien
reviewed
Oct 7, 2024
Stebalien
approved these changes
Oct 7, 2024
masih
force-pushed
the
masih/f3-participation-token
branch
from
ec3b3f0
to
3dcdb91
Compare
Stebalien
approved these changes
Oct 7, 2024
masih
force-pushed
the
masih/f3-participation-token
branch
from
3dcdb91
to
e7b8b5a
Compare
Implemented enhanced ticket-based participation system for F3 consensus in `F3Participate`. This update introduces a new design where participation tickets grant a temporary lease, allowing storage providers to sign as part of the F3 consensus mechanism. This design ensures that tickets are checked for validity and issuer alignment, handling errors robustly. If there's an issuer mismatch, the system advises miners to retry with the existing ticket. If the ticket is invalid or expired, miners are directed to obtain a new ticket via `F3GetOrRenewParticipationTicket`. Fixes filecoin-project/go-f3#599
To avoid potential of deadlock in case f3Participator is used from multiple goroutines use throw-away timers at the price of higher GC. Also use the cancel function in context explicitly in a unified stop hook that awaits the participation to end before exiting.
Require the start instance of a participation to never decrease if there is an existing lease by the miner.
Stebalien
force-pushed
the
masih/f3-participation-token
branch
2 times, most recently
from
523dff4
to
cd82c4e
Compare
That way we don't re-use leases across networks. It's a bit racy (we ask for the manifest before we ask for the current progress) but it should be fine because at least we won't create a lease for the new network with a future instance. There's still an ABA problem if we rapidly switch back and forth between two networks but... let's just not do that? At least for the mainnet switchover, that won't be an issue because we enforce a 900 epoch silence period. I have to say, I'm not happy about this. But... we can probably just hard-code it in the future once we get rid of the dynamic manifest.
Stebalien
force-pushed
the
masih/f3-participation-token
branch
from
cd82c4e
to
f1e21bf
Compare
Back off and get a fresh token if F3 is not ready.
masih
force-pushed
the
masih/f3-participation-token
branch
from
034b073
to
73359d6
Compare
rjan90
pushed a commit
that referenced
this pull request
Oct 8, 2024
* Implement ticket based F3 participation lease Implemented enhanced ticket-based participation system for F3 consensus in `F3Participate`. This update introduces a new design where participation tickets grant a temporary lease, allowing storage providers to sign as part of the F3 consensus mechanism. This design ensures that tickets are checked for validity and issuer alignment, handling errors robustly. If there's an issuer mismatch, the system advises miners to retry with the existing ticket. If the ticket is invalid or expired, miners are directed to obtain a new ticket via `F3GetOrRenewParticipationTicket`. Fixes filecoin-project/go-f3#599 * Use fresh timer every time for F3 backoffs To avoid potential of deadlock in case f3Participator is used from multiple goroutines use throw-away timers at the price of higher GC. Also use the cancel function in context explicitly in a unified stop hook that awaits the participation to end before exiting. * Strictly require start instance to never decrease Require the start instance of a participation to never decrease if there is an existing lease by the miner. * feat(f3): update go-f3 to 0.7.0 and adapt for changes to the API * feat(f3): Include the network name in the lease That way we don't re-use leases across networks. It's a bit racy (we ask for the manifest before we ask for the current progress) but it should be fine because at least we won't create a lease for the new network with a future instance. There's still an ABA problem if we rapidly switch back and forth between two networks but... let's just not do that? At least for the mainnet switchover, that won't be an issue because we enforce a 900 epoch silence period. I have to say, I'm not happy about this. But... we can probably just hard-code it in the future once we get rid of the dynamic manifest. * Handle not ready error gracefully in participator Back off and get a fresh token if F3 is not ready. --------- Co-authored-by: Steven Allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
Implemented enhanced ticket-based participation system for F3 consensus in
F3Participate. This update introduces a new design where participation tickets grant a temporary lease, allowing storage providers to sign as part of the F3 consensus mechanism. This design ensures that tickets are checked for validity and issuer alignment, handling errorsrobustly. If there's an issuer mismatch, the system advises miners to retry with the existing ticket. If the ticket is invalid or expired, miners are directed to obtain a new ticket via
F3GetOrRenewParticipationTicket.Additional Info
Checklist
Before you mark the PR ready for review, please make sure that: