Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release Lotus Node v1.31.1-rc1 #12833

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Jan 20, 2025

Related Issues

#12827

Proposed Changes

  • Prep Lotus Node v1.31.1-rc1 release

Checklist

Before you mark the PR ready for review, please make sure that:

chore: bump version to v1.31.1-rc1

Trigger CI/CD pipeline
@rjan90 rjan90 added the skip/changelog This change does not require CHANGELOG.md update label Jan 20, 2025
chore: update changelog for v1.31.1-rc1
@rjan90
Copy link
Contributor Author

rjan90 commented Jan 20, 2025

PRs called out in the changelog: npx branch-diff origin/release/v1.31.0 origin/release/v1.31.1 --user filecoin-project --repo lotus --md

✅ * [4a66850784] - feat(shed): cron queue inspection util (ZenGround0) #12825
✅ * [0e4857a11b] - feat(shed): lotus-shed msg --gas-stats (w/ tabular output) (Rod Vagg) #12817
✅ * [31c3a60721] - fix(indexer): fix potential panic in chain reconciliation logic during backfill (parthshah1) #12813
✅ * [5e566ba8ae] - feat: generate default configs for docs without compiled binaries (Rod Vagg)
✅ * [942094cbf3] - feat: separate docsgen-config Makefile target (Rod Vagg)
✅ * [ed4ea55cc6] - feat: generate CLI docs without needing compiled binaries (Aryan Tikarya)
✅ * [edfa817daf] - chore(eth): refactor eth API module into separate pieces in new pkg (Rod Vagg) #12796
✅ * [a5847457fd] - feat: add network tag to metrics (Viraj Bhartiya) #12733
✅ * [08acfa5bd7] - chore(bootstrap): magik bootstrap nodes (Łukasz Magiera) #12792
✅ * [e7db584232] - feat(gateway): add F3GetCertificate & F3GetLatestCertificate to gateway (Rod Vagg) #12778
✅ * [4f29e2ecaa] - chore: more frequent migration progress logs (Viraj Bhartiya) #12732
✅ * [9bfd0b4295] - chore: remove IPNI advertisement relay over pubsub via Lotus node (Masih H. Derkani) #12768
✅ * [6347eff776] - feat(cli): enhance ChainListCmd with JSON output and <epoch> placeholder support (Jakub Sztandera) #12691
✅ * [b37410b467] - fix: f3 gen power command being non-deterministic (Jakub Sztandera) #12764
✅ * [65230de10c] - fix(sync): do not allow to expand checkpointed tipsets (Jakub Sztandera) #12747
✅ * [c6d2e700ab] - fix(eth_trace): don't decode return value in EAM create error case (Rod Vagg) #12730
✅ * [64736eaab0] - feat: api: market pending proposal API/CLI (Łukasz Magiera) #12724
✅ * [f4dbd88f45] - fix: ChainIndexer#GetMsgInfo returns an ErrNotFound when there are no rows (Viraj Bhartiya) #12680
✅ * [4f923484bd] - feat(events): add max results error and default raw codec for eth_getLogs (Aryan Tikarya) #12671
✅ * [8003997b85] - fix(eth): make trace_filter resilient to null rounds (Rod Vagg) #12702

chore: clean up duplicate entries in changelog
@rjan90 rjan90 requested a review from rvagg January 20, 2025 15:13
@rjan90 rjan90 marked this pull request as ready for review January 20, 2025 15:13
Copy link
Member

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but would be good to get @rvagg check too.

CHANGELOG.md Outdated Show resolved Hide resolved
@BigLep
Copy link
Member

BigLep commented Jan 20, 2025

Non blocking thoughts, particularly about #12833 (comment)

  1. I think it would be a bit helpful if they were grouped by area. (For example, it I would want to see the "docs" items separated out to make sure I'm not missing any non-doc items).
  2. What do the "* ✅" items mean vs the "non ✅" items?
    • Doh, I see. ✅ are items in manually created changelog.
  3. I assume there aren't any dependency updates we need to call out (e.g., Proofs)?

@rvagg
Copy link
Member

rvagg commented Jan 20, 2025

@rjan90 shouldn't this PR be against release/v1.31.1?

@rvagg
Copy link
Member

rvagg commented Jan 20, 2025

Changelog entry for #12724 seems to have got lost (not marked as ticked above). It adds StateMarketProposalPending, so the original entry could be improved to be:

- Add `StateMarketProposalPending` API / `lotus state market proposal-pending` CLI. ([filecoin-project/lotus#12724](https://github.com/filecoin-project/lotus/pull/12724))

@rjan90 rjan90 changed the base branch from master to release/v1.31.1 January 21, 2025 07:25
chore: address changelog reviews
@rjan90
Copy link
Contributor Author

rjan90 commented Jan 21, 2025

Pushed a couple of updates from reviews e09e988:

@rjan90
Copy link
Contributor Author

rjan90 commented Jan 21, 2025

I think it would be a bit helpful if they were grouped by area. (For example, it I would want to see the "docs" items separated out to make sure I'm not missing any non-doc items).

Sorted the list a little bit by moving all the ✅ to the top, and moved all typo fixing, and docs related items to the bottom of the list.

I assume there aren't any dependency updates we need to call out (e.g., Proofs)?

Correct.

@rjan90 rjan90 merged commit b81f548 into release/v1.31.1 Jan 21, 2025
88 checks passed
@rjan90 rjan90 deleted the phi/prep-v1.31.1-rc1 branch January 21, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

3 participants