Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tstore fevm test #12849

Merged
merged 7 commits into from
Jan 31, 2025
Merged

feat: tstore fevm test #12849

merged 7 commits into from
Jan 31, 2025

Conversation

snissn
Copy link
Contributor

@snissn snissn commented Jan 26, 2025

Related Issues

filecoin-project/go-state-types#340

The PR 340 in go state types is needed for the tests in this PR to pass.

Proposed Changes

add tests for transient storage that asserts that there is no support for transient storage in the evm, migrates to nv16, then asserts that there is support for transient storage after the migration

Additional Info

filecoin-project/FIPs#1084

Checklist

Before you mark the PR ready for review, please make sure that:

… Because the network upgrade does not happen the tests currently fail so they are commented with what needs to change once the network upgrade can be wired in.
@snissn snissn requested review from rvagg and rjan90 January 26, 2025 19:52
@rjan90 rjan90 linked an issue Jan 27, 2025 that may be closed by this pull request
@snissn snissn added the skip/changelog This change does not require CHANGELOG.md update label Jan 27, 2025
@BigLep
Copy link
Member

BigLep commented Jan 29, 2025

2025-01-29 conversation: this will be ready for review once filecoin-project/go-state-types#340 lands

@rvagg
Copy link
Member

rvagg commented Jan 30, 2025

seems good to me, just need dependencies to be updated

@rjan90
Copy link
Contributor

rjan90 commented Jan 30, 2025

@snissn
Copy link
Contributor Author

snissn commented Jan 30, 2025

I changed the version of go-state-types to rc3 and ran go mod tidy which updated go.sum 797ee4c

I also ran make bundle-gen and bash pack.sh v16 v16.0.0-dev1 and commited those changes in build/builtin_actors_gen.go and in build/actors/v16.tar.zst f5ea560

itests pass locally for me! at the moment github tests are still pending

@rjan90
Copy link
Contributor

rjan90 commented Jan 31, 2025

Looks good to me. Did a sanity test of the migration in a local devnet as well:

At start:

lotus state actor-cids 
Network Version: 24
Actor Version: 15
Manifest CID: bafy2bzacedlusqjwf7chvl2ve2fum5noyqrtjzcrzkhpbzpkg7puiru7dj4ug

Pre-migration:

2025-01-31T11:24:15.051+0100	WARN	statemgr	stmgr/forks.go:250	STARTING pre-migration
2025-01-31T11:24:15.052+0100	INFO	bundle	bundle/bundle.go:60	manifest cid: bafy2bzacebdyuvdaovs5lnwfnn2uu5ckvinokhctuym2wt4zradxmb2emh3gu
2025-01-31T11:24:15.105+0100	INFO	fil-consensus	filcns/upgrades.go:3012	Started 5 workers
2025-01-31T11:24:15.105+0100	INFO	fil-consensus	filcns/upgrades.go:3012	Creating migration jobs
2025-01-31T11:24:15.106+0100	INFO	fil-consensus	filcns/upgrades.go:3012	Result writer started
2025-01-31T11:24:15.106+0100	INFO	fil-consensus	filcns/upgrades.go:3012	Done creating 17 migration jobs after 0s
2025-01-31T11:24:15.106+0100	INFO	fil-consensus	filcns/upgrades.go:3012	All workers done after 0s
2025-01-31T11:24:15.106+0100	INFO	fil-consensus	filcns/upgrades.go:3012	Result writer wrote 17 results to state tree after 0s
2025-01-31T11:24:15.106+0100	INFO	fil-consensus	filcns/upgrades.go:3012	All 17 done after 0s (25011/s)
2025-01-31T11:24:15.114+0100	WARN	statemgr	stmgr/forks.go:263	COMPLETED pre-migration	{"duration": 0.062895833}

Migration:

2025-01-31T11:32:21.204+0100	WARN	statemgr	stmgr/forks.go:202	STARTING migration	{"height": "200", "from": "bafy2bzacec7jzkceewiggy4xzozs2znbymm4q3hzzadudh6woofkhbcpd7yia"}
2025-01-31T11:32:21.205+0100	INFO	bundle	bundle/bundle.go:60	manifest cid: bafy2bzacebdyuvdaovs5lnwfnn2uu5ckvinokhctuym2wt4zradxmb2emh3gu
2025-01-31T11:32:21.206+0100	INFO	fil-consensus	filcns/upgrades.go:3012	Started 7 workers
2025-01-31T11:32:21.206+0100	INFO	fil-consensus	filcns/upgrades.go:3012	Creating migration jobs
2025-01-31T11:32:21.206+0100	INFO	fil-consensus	filcns/upgrades.go:3012	Done creating 17 migration jobs after 0s
2025-01-31T11:32:21.206+0100	INFO	fil-consensus	filcns/upgrades.go:3012	Result writer started
2025-01-31T11:32:21.207+0100	INFO	fil-consensus	filcns/upgrades.go:3012	All workers done after 0s
2025-01-31T11:32:21.207+0100	INFO	fil-consensus	filcns/upgrades.go:3012	Result writer wrote 17 results to state tree after 0s
2025-01-31T11:32:21.207+0100	INFO	fil-consensus	filcns/upgrades.go:3012	All 17 done after 0s (16841/s)
2025-01-31T11:32:21.207+0100	WARN	statemgr	stmgr/forks.go:211	COMPLETED migration	{"height": "200", "from": "bafy2bzacec7jzkceewiggy4xzozs2znbymm4q3hzzadudh6woofkhbcpd7yia", "to": "bafy2bzaceapjagh6zgdzlymbouahqnpf2rmlsaujubagyi6akzi5z7rp6rkgq", "duration": 0.003187833}

After migration:

lotus state actor-cids
Network Version: 25
Actor Version: 16
Manifest CID: bafy2bzacebdyuvdaovs5lnwfnn2uu5ckvinokhctuym2wt4zradxmb2emh3gu

@rjan90 rjan90 merged commit a526c48 into master Jan 31, 2025
84 checks passed
@rjan90 rjan90 deleted the mikers/tstore_fevm_test branch January 31, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

itest for TSTORE and TLOAD OP Codes in FEVM
4 participants