Skip to content

Commit

Permalink
ci: disable always failing windows pr builds (#1322)
Browse files Browse the repository at this point in the history
* ci: disable always failing windows pr builds

* fix ignore subsequent steps

actions/runner#662
  • Loading branch information
juliangruber authored Feb 9, 2024
1 parent ff2d0f6 commit e924e5a
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,9 @@ jobs:
DEBUG: electron-builder

- name: Build binaries with electron-builder (Windows)
if: ${{ matrix.os == 'windows-latest' }}
# Windows builds are always failing in PRs. We should fix them, but for
# now let's just skip them to remove noise.
if: ${{ matrix.os == 'windows-latest' && github.event_name != 'pull_request' }}
run: |
npm run build
npm exec -- electron-builder --publish onTag
Expand Down Expand Up @@ -194,18 +196,21 @@ jobs:
USE_HARD_LINKS: false

- name: Show dist/
if: ${{ !(matrix.os == 'windows-latest' && github.event_name == 'pull_request') }}
run: du -sh dist/ && ls -l dist/

# Persist produced binaries and effective config used for building them
# - this is not for releases, but for quick testing during the dev
# - action artifacts can be downloaded for 90 days, then are removed by github
# - binaries in PRs from forks won't be signed
- name: Attach produced packages to Github Action
if: ${{ !(matrix.os == 'windows-latest' && github.event_name == 'pull_request') }}
uses: actions/upload-artifact@v4
with:
name: dist-${{ matrix.os }}
path: dist/*tation*.*
if-no-files-found: error

- name: Show Cache
if: ${{ !(matrix.os == 'windows-latest' && github.event_name == 'pull_request') }}
run: du -sh ${{ github.workspace }}/.cache/ && ls -l ${{ github.workspace }}/.cache/

0 comments on commit e924e5a

Please sign in to comment.