Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add retry e2e tests #1929

Merged
merged 5 commits into from
Nov 27, 2024
Merged

ci: add retry e2e tests #1929

merged 5 commits into from
Nov 27, 2024

Conversation

juliangruber
Copy link
Member

@juliangruber juliangruber commented Nov 21, 2024

Trying out the two main retry actions here

Motivation: It's annoying to restart runs because the e2e test suite failed with some arbitrary machine / tooling timeout. Example: https://github.com/filecoin-station/desktop/actions/runs/11945473489/job/33298198746?pr=1928

https://github.com/marketplace/actions/retry-step

https://github.com/marketplace/actions/retry-action

@juliangruber
Copy link
Member Author

Interesting: It failed twice here: https://github.com/filecoin-station/desktop/actions/runs/11949394698/job/33308751848?pr=1929

Options:

  • Add a delay between runs
  • Add more attempts
  • Could it be a worker problem, and we need to restart the whole workflow?

@juliangruber juliangruber marked this pull request as ready for review November 22, 2024 21:35
@juliangruber juliangruber requested a review from bajtos November 22, 2024 21:35
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

I don't see any obvious problems. Let's see how this works in practice and iterate on further improvements.

@bajtos bajtos enabled auto-merge (squash) November 27, 2024 12:55
@bajtos bajtos merged commit ad95f85 into main Nov 27, 2024
11 checks passed
@bajtos bajtos deleted the add/ci-retry-e2e branch November 27, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants