Implemented compression in properties #16319
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x5bfa
reviewed
Oct 17, 2024
There was a problem hiding this comment.
Please revert changes in this file.
src/Files.App/ViewModels/Properties/Items/CombinedProperties.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: 0x5BFA <[email protected]>
Co-authored-by: 0x5BFA <[email protected]>
Co-authored-by: 0x5BFA <[email protected]>
Co-authored-by: 0x5BFA <[email protected]>
Co-authored-by: 0x5BFA <[email protected]>
|
@0x5bfa I implemented the changes you requested. Unfortunately, some of them didn't compile and CsWin32 didn't feel like SG-ing enums for me so I reverted to the old values. |
|
Can you try to add "COMPRESSION_FORMAT" and "FILE_ACCESS_RIGHTS" in NativeMethods.txt beforehand and use these enums? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR continues on the work made in the ya/CompressedAttribute branch and fixes the broken logic to actually enable/disable compression for items
FYI @yaira2
Resolved / Related Issues
Todo
FILE_FILE_COMPRESSIONattribute