fixing filodb's github test action workflow (#1928) #1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rows() is a closable resources. We can use Using to protect it. However, the current logic calls rows() twice and only close it once. This commit would fix this issue. Co-authored-by: Yu Zhang <[email protected]>
RepeatTransformer should be added as a case. Co-authored-by: Yu Zhang <[email protected]>
…needed (filodb#1934) * Planning for local and remote clusters only if absolutely needed. * fixing scalastyle --------- Co-authored-by: Kier Petrov <[email protected]>
…ilodb#1932) * query(fix) schema mismatch due to different length of data points. Some number of data points are different for different time series. Use the longer length as the result. --------- Co-authored-by: Yu Zhang <[email protected]>
alextheimer
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Current behavior : (link exiting issues here : https://help.github.com/articles/basic-writing-and-formatting-syntax/#referencing-issues-and-pull-requests)
New behavior :
BREAKING CHANGES
If this PR contains a breaking change, please describe the impact and migration
path for existing applications.
If not please remove this section.
Breaking changes may include:
Other information: