-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docstrings to Foundation Models #248
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laurent2916
force-pushed
the
pr/add-docstrings
branch
from
February 2, 2024 14:10
398a161
to
b49e438
Compare
deltheil
reviewed
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments/suggestions, PTAL (feel free to squash the (extra) commits ultimately)
src/refiners/foundationals/latent_diffusion/stable_diffusion_xl/model.py
Show resolved
Hide resolved
src/refiners/foundationals/latent_diffusion/stable_diffusion_xl/model.py
Outdated
Show resolved
Hide resolved
Laurent2916
force-pushed
the
pr/add-docstrings
branch
from
February 2, 2024 15:05
a277700
to
0a47f5c
Compare
deltheil
approved these changes
Feb 2, 2024
Laurent2916
force-pushed
the
pr/add-docstrings
branch
from
February 2, 2024 16:26
d555925
to
cbffbc6
Compare
…s/latent_diffusion/stable_diffusion_xl/__init__.py`
Laurent2916
force-pushed
the
pr/add-docstrings
branch
from
February 2, 2024 16:31
cbffbc6
to
1cbad09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm vetoing writing docstrings for at least a month 💀.