Support broadcast in FDC3 Action

[symphony-jean-michael]

This PR applies the changes requested in the Enhancement Request: #1353

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: symphony-jean-michael / name: Jean-Michael Legait (eba30bb, f9fc79a, 0ce367a, bd71172, 4f34a71)

[netlify]

✅ Deploy Preview for fdc3 ready!

Name	Link
🔨 Latest commit	4f34a71
🔍 Latest deploy log	https://app.netlify.com/sites/fdc3/deploys/670cee97044cae000887c496
😎 Deploy Preview	https://deploy-preview-1368--fdc3.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[kriswest]

Need to move some of the descriptive content into the schema and run the generator. See comments for details.

[symphony-jean-michael]

Hi @kriswest
Thank you for your help.
I've modified the PR according to your comments. Now only the action.schema.json file has been updated.

[kriswest]

This looks good to me now.

I wasn't super clear in the previous comment about files to include - action.schema.json is the only file that needs to be touched manually. However, ContextTypes.ts should still make it into the PR - its generated on running npm run typegen or npm run build. Its setup to happen automatically on a precommit hook - but then it probably doesn't add the generated file to the commit.

Not a problem for merging this PR as it will happen alter before release.

[kriswest]

Apologies spotted a small typo which lead to realising a part of the content needed a further tweak

[symphony-jean-michael]

@kriswest Thank you for your help. I committed your suggestion.

[kriswest]

Hi @symphony-jean-michael, looking good now - just needs a changelog entry adding: https://github.com/symphony-jean-michael/FDC3/blob/broadcast_in_action/CHANGELOG.md

I would suggest something like the following (in the 'Added' section):

- Added support for broadcast actions to the `fdc3.action` context type, allowing an Action to represent the broadcast of a specified context to an app or user channel. ([#1368](https://github.com/finos/FDC3/pull/1368))

You could also run npm run build in the root of the project before checking in so that ContextTYpes.ts gets regenerated.

We're going to add a PR template to the project soon with checkboxes for things like this to avoid slow back and forth on reviews like this ;-)

[symphony-jean-michael]

Hi @kriswest
I updated the Changelog file. :)

[kriswest]

Hi @kriswest I updated the Changelog file. :)

Don't forget to push the change (not seeing it yet - but then github seems to be under particularly high load this morning so it may be them). Please add /src/ContextTypes.ts as well (should have changes after running npm run build).

[symphony-jean-michael]

@kriswest Yes it seems to take time. 😅

[kriswest]

LGTM

Some of the changes in the ContextTypes.ts file aren't great (types relating to SearchCriteria), but I don't think they relate to this PR. We'll work on those before releasing 2.2.