Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fdc3 for web impl update #1392

Open
wants to merge 94 commits into
base: fdc3-for-web-impl
Choose a base branch
from
Open

Conversation

kriswest
Copy link
Contributor

@kriswest kriswest commented Oct 17, 2024

Merges recent changes from the fdc3-for-web branch + main into fdc3-for-web-impl.

Fixes applied for:

  • Renamed iframe messages
  • heartbeat handling
  • window.fdc3 being optional (in Methods.ts)
  • Corrected casing of privateChannelAddEventListenerRequest/Response

YaoYao-dd and others added 30 commits July 21, 2024 22:49
… be consistent, both use ticker, 2. content data standard defines instrument with ticker
…-while-poc-fdc3

Clarify document while poc fdc3
…ttps/fdc3.finos.org/docs/next/api/spec

fix Broken-link-in-https/fdc3.finos.org/docs/next/api/spec
Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.21.0.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](expressjs/express@4.19.2...4.21.0)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
…xpress-4.21.0

Bump express from 4.19.2 to 4.21.0 in /website
Set explicit background colours for website
Add missing id/name fields to context schema docs
@kriswest kriswest requested a review from a team as a code owner October 17, 2024 10:07
console.error(`${resolution.source} returned a result error: ${error}`);
try {
const result = await resolution.getResult();
console.log(`${resolution.source} returned ${JSON.stringify(result)}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
console.log(`${resolution.source} returned ${JSON.stringify(result)}`);
console.log(resolution.source, " returned ", result);

Copy link
Contributor

@julianna-ciq julianna-ciq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving within the context of the addon changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants